s3rius/squeekboard
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

caches: Stop using due to bugginness

Browse Source 
The button cache is storing only button outlines (not useful to us), and it only cares about active/inactive states (there are more).

This will have to be rewritten sanely, so for the time being, disabling it is not going to deal a big performance penalty.
This commit is contained in:
Dorota Czaplejewicz
2019-10-09 09:23:50 +00:00
parent 31fdde4da9
commit 212e55d7cf
1 changed files with 1 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
eek/eek-renderer.c
View File

@ -193,12 +193,7 @@ static void render_button_in_context(EekRenderer *self,
/* render outline */ /* render outline */
EekBounds bounds = squeek_button_get_bounds(place->button); EekBounds bounds = squeek_button_get_bounds(place->button);
if (active) outline_surface = NULL;
outline_surface_cache = priv->active_outline_surface_cache;
else
outline_surface_cache = priv->outline_surface_cache;
outline_surface = g_hash_table_lookup (outline_surface_cache, place->button);
if (!outline_surface) { if (!outline_surface) {
cairo_t *cr; cairo_t *cr;
@ -221,10 +216,6 @@ static void render_button_in_context(EekRenderer *self,
cairo_restore (cr); cairo_restore (cr);
cairo_destroy (cr); cairo_destroy (cr);
g_hash_table_insert (outline_surface_cache,
(gpointer)place->button,
outline_surface);
} }
cairo_set_source_surface (cr, outline_surface, 0.0, 0.0); cairo_set_source_surface (cr, outline_surface, 0.0, 0.0);
cairo_paint (cr); cairo_paint (cr);