keyboard: Drop layout reference

This commit is contained in:
Dorota Czaplejewicz
2019-08-05 11:35:25 +00:00
parent d6b59d16fd
commit 754e79103a
3 changed files with 1 additions and 52 deletions

View File

@ -41,7 +41,6 @@
enum { enum {
PROP_0, PROP_0,
PROP_LAYOUT,
PROP_MODIFIER_BEHAVIOR, PROP_MODIFIER_BEHAVIOR,
PROP_LAST PROP_LAST
}; };
@ -67,7 +66,6 @@ static guint signals[LAST_SIGNAL] = { 0, };
struct _EekKeyboardPrivate struct _EekKeyboardPrivate
{ {
EekLayout *layout;
EekModifierBehavior modifier_behavior; EekModifierBehavior modifier_behavior;
EekModifierType modifiers; EekModifierType modifiers;
unsigned int old_level; unsigned int old_level;
@ -172,14 +170,7 @@ eek_keyboard_set_property (GObject *object,
const GValue *value, const GValue *value,
GParamSpec *pspec) GParamSpec *pspec)
{ {
EekKeyboardPrivate *priv = EEK_KEYBOARD_GET_PRIVATE(object);
switch (prop_id) { switch (prop_id) {
case PROP_LAYOUT:
priv->layout = g_value_get_object (value);
if (priv->layout)
g_object_ref (priv->layout);
break;
case PROP_MODIFIER_BEHAVIOR: case PROP_MODIFIER_BEHAVIOR:
eek_keyboard_set_modifier_behavior (EEK_KEYBOARD(object), eek_keyboard_set_modifier_behavior (EEK_KEYBOARD(object),
g_value_get_enum (value)); g_value_get_enum (value));
@ -196,12 +187,7 @@ eek_keyboard_get_property (GObject *object,
GValue *value, GValue *value,
GParamSpec *pspec) GParamSpec *pspec)
{ {
EekKeyboardPrivate *priv = EEK_KEYBOARD_GET_PRIVATE(object);
switch (prop_id) { switch (prop_id) {
case PROP_LAYOUT:
g_value_set_object (value, priv->layout);
break;
case PROP_MODIFIER_BEHAVIOR: case PROP_MODIFIER_BEHAVIOR:
g_value_set_enum (value, g_value_set_enum (value,
eek_keyboard_get_modifier_behavior (EEK_KEYBOARD(object))); eek_keyboard_get_modifier_behavior (EEK_KEYBOARD(object)));
@ -384,13 +370,6 @@ void eek_keyboard_release_key( EekKeyboard *keyboard,
static void static void
eek_keyboard_dispose (GObject *object) eek_keyboard_dispose (GObject *object)
{ {
EekKeyboardPrivate *priv = EEK_KEYBOARD_GET_PRIVATE(object);
if (priv->layout) {
g_object_unref (priv->layout);
priv->layout = NULL;
}
G_OBJECT_CLASS (eek_keyboard_parent_class)->dispose (object); G_OBJECT_CLASS (eek_keyboard_parent_class)->dispose (object);
} }
@ -456,20 +435,6 @@ eek_keyboard_class_init (EekKeyboardClass *klass)
gobject_class->dispose = eek_keyboard_dispose; gobject_class->dispose = eek_keyboard_dispose;
gobject_class->finalize = eek_keyboard_finalize; gobject_class->finalize = eek_keyboard_finalize;
/**
* EekKeyboard:layout:
*
* The layout used to create this #EekKeyboard.
*/
pspec = g_param_spec_object ("layout",
"Layout",
"Layout used to create the keyboard",
EEK_TYPE_LAYOUT,
G_PARAM_CONSTRUCT_ONLY | G_PARAM_READWRITE);
g_object_class_install_property (gobject_class,
PROP_LAYOUT,
pspec);
/** /**
* EekKeyboard:modifier-behavior: * EekKeyboard:modifier-behavior:
* *
@ -569,20 +534,6 @@ eek_keyboard_find_key_by_name (EekKeyboard *keyboard,
name); name);
} }
/**
* eek_keyboard_get_layout:
* @keyboard: an #EekKeyboard
*
* Get the layout used to create @keyboard.
* Returns: an #EekLayout
*/
EekLayout *
eek_keyboard_get_layout (EekKeyboard *keyboard)
{
g_return_val_if_fail (EEK_IS_KEYBOARD(keyboard), NULL);
return keyboard->priv->layout;
}
/** /**
* eek_keyboard_get_size: * eek_keyboard_get_size:
* @keyboard: an #EekKeyboard * @keyboard: an #EekKeyboard

View File

@ -131,8 +131,6 @@ EekKeyboard *eek_keyboard_new (EekboardContextService *manager,
gdouble initial_height); gdouble initial_height);
GType eek_keyboard_get_type GType eek_keyboard_get_type
(void) G_GNUC_CONST; (void) G_GNUC_CONST;
EekLayout *eek_keyboard_get_layout
(EekKeyboard *keyboard);
void eek_keyboard_get_size void eek_keyboard_get_size
(EekKeyboard *keyboard, (EekKeyboard *keyboard,
gdouble *width, gdouble *width,

View File

@ -892,7 +892,7 @@ eek_xml_layout_real_create_keyboard (EekboardContextService *manager,
/* Create an empty keyboard to which geometry and symbols /* Create an empty keyboard to which geometry and symbols
information are applied. */ information are applied. */
EekKeyboard *keyboard = g_object_new (EEK_TYPE_KEYBOARD, "layout", layout, NULL); EekKeyboard *keyboard = g_object_new (EEK_TYPE_KEYBOARD, NULL);
keyboard->manager = manager; keyboard->manager = manager;
/* Read geometry information. */ /* Read geometry information. */