s3rius/squeekboard
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

text input: Disable erasing

Browse Source 
Erasing with zwp_text_input_v3 version 1 requires bytes, and bytes require get_surrounding_text. That, however, is optional. That's a mistake in protocol design.

Easiest to drop this until the mess is solved on the protocol side.
This commit is contained in:
Dorota Czaplejewicz
2020-02-12 10:56:07 +00:00
parent a57a78aa2e
commit 85be855032
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/submission.rs
View File

@ -139,6 +139,9 @@ impl Submission {
Err(imservice::SubmitError::NotActive) => false, Err(imservice::SubmitError::NotActive) => false,
} }
}, },
/* Delete_surrounding_text takes byte offsets,
* so cannot work without get_surrounding_text.
* This is a bug in the protocol.
(Some(imservice), Action::Erase) => { (Some(imservice), Action::Erase) => {
let submit_result = imservice.delete_surrounding_text(1, 0) let submit_result = imservice.delete_surrounding_text(1, 0)
.and_then(|_| imservice.commit()); .and_then(|_| imservice.commit());
@ -146,7 +149,7 @@ impl Submission {
Ok(()) => true, Ok(()) => true,
Err(imservice::SubmitError::NotActive) => false, Err(imservice::SubmitError::NotActive) => false,
} }
} }*/
(_, _) => false, (_, _) => false,
}; };