s3rius/squeekboard
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Clarify some arithmetic warnings

Browse Source
This commit is contained in:
Dorota Czaplejewicz
2019-08-05 11:40:06 +00:00
parent 3e35b7441e
commit f7d30b0df3
1 changed files with 7 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
eek/eek-renderer.c
View File

@ -291,8 +291,8 @@ render_key (EekRenderer *self,
cairo_save (cr); cairo_save (cr);
cairo_translate (cr, cairo_translate (cr,
(bounds.width - width / scale) / 2, (bounds.width - (double)width / scale) / 2,
(bounds.height - height / scale) / 2); (bounds.height - (double)height / scale) / 2);
cairo_rectangle (cr, 0, 0, width, height); cairo_rectangle (cr, 0, 0, width, height);
cairo_clip (cr); cairo_clip (cr);
/* Draw the shape of the icon using the foreground color */ /* Draw the shape of the icon using the foreground color */
@ -316,8 +316,8 @@ render_key (EekRenderer *self,
cairo_save (cr); cairo_save (cr);
cairo_move_to cairo_move_to
(cr, (cr,
(bounds.width - extents.width / PANGO_SCALE) / 2, (bounds.width - (double)extents.width / PANGO_SCALE) / 2,
(bounds.height - extents.height / PANGO_SCALE) / 2); (bounds.height - (double)extents.height / PANGO_SCALE) / 2);
cairo_set_source_rgba (cr, cairo_set_source_rgba (cr,
foreground.red, foreground.red,
@ -766,8 +766,8 @@ eek_renderer_set_allocation_size (EekRenderer *renderer,
priv->scale = scale; priv->scale = scale;
/* Set the rendering offset in widget coordinates to center the keyboard */ /* Set the rendering offset in widget coordinates to center the keyboard */
priv->origin_x = (width - (scale * w)) / 2; priv->origin_x = (gint)floor((width - (scale * w)) / 2);
priv->origin_y = (height - (scale * h)) / 2; priv->origin_y = (gint)floor((height - (scale * h)) / 2);
invalidate (renderer); invalidate (renderer);
} }
@ -1007,6 +1007,7 @@ typedef struct _FindKeyByPositionCallbackData FindKeyByPositionCallbackData;
static gboolean static gboolean
sign (EekPoint *p1, EekPoint *p2, EekPoint *p3) sign (EekPoint *p1, EekPoint *p2, EekPoint *p3)
{ {
// FIXME: what is this actually checking?
return (p1->x - p3->x) * (p2->y - p3->y) - return (p1->x - p3->x) * (p2->y - p3->y) -
(p2->x - p3->x) * (p1->y - p3->y); (p2->x - p3->x) * (p1->y - p3->y);
} }